feat: skills for declarative agents by yuval-k · Pull Request #1077 · kagent-dev/kagent

yuval-k · 2025-10-30T21:40:58Z

pull in skills to the agent from a docker registry. This is done in an init container:

so it also works for BYO agents (i.e. this part is now not framework dependent)
so it skills fails to pull the pod fails to start, i think that would give better feedback for users

follow up tasks

use a different venv for sandbox with bunch of python packages
maybe: support multiple skills in one image
validate the skill image has a SKILL.md file and is at most 10MB
make running code not require privileged

Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>

Copilot

Pull Request Overview

This PR adds support for code execution and skill loading capabilities to KAgent. The changes enable agents to execute Python code in a sandboxed environment and load skills from OCI/Docker container images.

Key changes:

Added sandboxed code execution using the srt (sandbox runtime) command
Implemented skill fetching from container registries using crane
Extended agent configuration to support code execution and skill loading via declarative specs
Refactored skills plugin to support programmatic addition of skills to agents

Reviewed Changes

Copilot reviewed 39 out of 40 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
python/packages/kagent-adk/src/kagent/adk/sandbox_code_executer.py	New sandboxed code executor implementation using `srt`
python/packages/kagent-adk/src/kagent/adk/skill_fetcher.py	New skill fetching utility to pull skills from OCI images
python/packages/kagent-adk/src/kagent/adk/types.py	Added code_executor parameter to agent configuration
python/packages/kagent-adk/src/kagent/adk/skills/skills_plugin.py	Extracted skill tool addition logic into reusable function
python/packages/kagent-adk/src/kagent/adk/cli.py	Added `--code` flag and `pull-skills` command; moved logging configuration
go/internal/controller/translator/agent/adk_api_translator.go	Added logic to generate init containers for skill fetching and configure sandbox security context
go/api/v1alpha2/agent_types.go	Extended agent spec with Skills and ExecuteCode fields
python/Dockerfile	Added installation of sandbox runtime and crane tool

Comments suppressed due to low confidence (3)

python/packages/kagent-adk/src/kagent/adk/skill_fetcher.py:34

This assignment to 'registry' is unnecessary as it is redefined before this value is used.
This assignment to 'registry' is unnecessary as it is redefined before this value is used.
python/packages/kagent-adk/src/kagent/adk/skill_fetcher.py:35
This assignment to 'repo' is unnecessary as it is redefined before this value is used.
This assignment to 'repo' is unnecessary as it is redefined before this value is used.
python/packages/kagent-adk/src/kagent/adk/cli.py:74
Unnecessary 'pass' statement.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

python/packages/kagent-adk/src/kagent/adk/sandbox_code_executer.py

python/packages/kagent-adk/src/kagent/adk/skill_fetcher.py

python/packages/kagent-adk/src/kagent/adk/skills/skills_plugin.py

python/packages/kagent-adk/src/kagent/adk/cli.py

python/packages/kagent-adk/src/kagent/adk/skill_fetcher.py

Copilot · 2025-10-31T14:57:30Z

python/packages/kagent-adk/src/kagent/adk/skill_fetcher.py

+    """
+    # Split digest if present
+    name_part = image
+    ref = "latest"


This assignment to 'ref' is unnecessary as it is redefined before this value is used.
This assignment to 'ref' is unnecessary as it is redefined before this value is used.

python/packages/kagent-adk/src/kagent/adk/skill_fetcher.py

go/api/v1alpha2/agent_types.go

EItanya · 2025-10-31T16:26:56Z

go/api/v1alpha2/agent_types.go

 	// +optional
 	Deployment *DeclarativeDeploymentSpec `json:"deployment,omitempty"`
+
+	ExecuteCode *bool `json:"executeCode,omitempty"`


Can we be more specific about this field name, specifically this executor will execute code that is returned from the API directly, not files or anything like that. Also, maybe this should be an struct as we may want to support multiple executors in the future?

changed to ExecuteCodeBlocks so it's more clear

go/internal/controller/translator/agent/adk_api_translator.go

python/Dockerfile

python/packages/kagent-adk/src/kagent/adk/skill_fetcher.py

Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>

peterj · 2025-11-01T07:09:44Z

go/internal/controller/translator/agent/adk_api_translator.go

+			Name:  "KAGENT_SKILLS_FOLDER",
+			Value: "/skills",
+		}
+		needSandbox = true


by setting this to true here, are saying that if you add skills to the agent you'll always also need a sandbox? Are there agents with skills that won't need to execute code?

there are skills that don't have code... but we don't know it ahead of time...

very initial code sandbox. With some hardcoded WIP changes

36b1958

Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>

yuval-k force-pushed the yuval-k/initial-code-sandbox branch from 88a94c7 to bafc8ca Compare October 31, 2025 13:07

yuval-k added 2 commits October 31, 2025 10:50

initial pull skills

a36e29c

Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>

more updates & add test skill

0547d52

Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>

yuval-k force-pushed the yuval-k/initial-code-sandbox branch from bafc8ca to b1d63d4 Compare October 31, 2025 14:51

yuval-k marked this pull request as ready for review October 31, 2025 14:51

yuval-k requested review from EItanya and ilackarms as code owners October 31, 2025 14:51

Copilot AI review requested due to automatic review settings October 31, 2025 14:51

yuval-k requested a review from peterj as a code owner October 31, 2025 14:51

Copilot AI reviewed Oct 31, 2025

View reviewed changes

EItanya reviewed Oct 31, 2025

View reviewed changes

yuval-k added 7 commits October 31, 2025 16:35

fetch skills with crane

ee7eb99

Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>

image name edge case

9aec2be

Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>

declarative skills smoke test seems to work

8b42700

Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>

add e2e test + cleanups

02f938c

Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>

updates translator tests. add code execution tests

a6cbddf

Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>

cleanup

4b120eb

Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>

PR feedback

a5fba86

Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>

yuval-k force-pushed the yuval-k/initial-code-sandbox branch from 659dd02 to a5fba86 Compare October 31, 2025 20:35

update translator tests

2205b14

Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>

peterj reviewed Nov 1, 2025

View reviewed changes

EItanya approved these changes Nov 3, 2025

View reviewed changes

EItanya merged commit d46efdc into main Nov 3, 2025
16 checks passed

EItanya deleted the yuval-k/initial-code-sandbox branch November 3, 2025 17:36

supreme-gg-gg mentioned this pull request Nov 3, 2025

feat: Use Sandbox Runtime for Bash tool and refactor artifact utils tools #1071

Merged

artberger mentioned this pull request Nov 21, 2025

Docs for agent skills kagent-dev/website#273

Merged

Conversation

yuval-k commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

EItanya Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

yuval-k Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

peterj Nov 1, 2025

Choose a reason for hiding this comment

Uh oh!

yuval-k Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yuval-k commented Oct 30, 2025 •

edited

Loading